Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update website v1.6 - update get started page version dropdown #1

Merged
merged 2 commits into from
May 6, 2020
Merged

update website v1.6 - update get started page version dropdown #1

merged 2 commits into from
May 6, 2020

Conversation

ys2843
Copy link
Contributor

@ys2843 ys2843 commented May 5, 2020

Resolved apache/mxnet#18238, please verify the change on version 1.6 get started page, tested the drop down. Please let me know if there is any problem. Thanks for reveiwing!

Comments

@ChaiBapchya
Copy link

Same story here
http://ec2-34-219-59-203.us-west-2.compute.amazonaws.com/versions/1.6/api/python/docs/api/optimizer/index.html

and then switching to any other version [e.g. master/1.5/1.4/... ] redirects to landing page

@connorgoggins
Copy link
Owner

@ChaiBapchya are you referring to the general website version dropdown? This fix is for the Get Started page dropdown, and the behavior you described is the same in the current production website.

Just wanted to clarify in case I'm missing something, did you see any issues with the Get Started dropdown fix? It looks fine to me.

@ys2843
Copy link
Contributor Author

ys2843 commented May 6, 2020

New preview link updated for today, please feel free to verify the change. Thanks

@ChaiBapchya
Copy link

@connorgoggins Thanks for clarifying. So this is only for "Get started" page.
But even then with
Screen Shot 2020-05-06 at 10 09 37 AM
Clicking on any other version directs to the landing page.Is this expected?

@connorgoggins
Copy link
Owner

@ChaiBapchya for the general version dropdown, yes, that is expected behavior. This fix is for the version selector dropdown on the Get Started page, not the general version dropdown:
Screen Shot 2020-05-06 at 10 31 39 AM

@ChaiBapchya
Copy link

Thanks for clarifying. LGTM then!

Copy link
Owner

@connorgoggins connorgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for your contribution :)

@connorgoggins connorgoggins merged commit 9ea104d into connorgoggins:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants